espressif / esp-rainmaker-android

ESP RainMaker Android app sources
https://rainmaker.espressif.com/
Apache License 2.0
95 stars 55 forks source link

added "colour selector" replacing slider for "hue" parameter #1

Closed manmohan777 closed 3 years ago

manmohan777 commented 3 years ago

I think selecting hue using a color selector is easier than a slider so I created a custom color selector and replaced the slider with the "hue" parameter.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

manmohan777 commented 3 years ago

WhatsApp Image 2020-10-30 at 10 40 59 AM WhatsApp Image 2020-10-30 at 10 38 19 AM PaletteBar View enabled and disabled state

shahpiyushv commented 3 years ago

@manmohan777 , thanks for the contribution. Something like this would definitely be useful as people can relate to visual colour more than the arcdegree value. However, this is not matching with rest of the theme of the app. Would it be possible to use something like this slider?

Moreover, the same UI element also needs to show up in the Schedule actions' screen. Internally, we are checking how we can better support this, so that contributors will need to add the UI element at only once place and not two.

manmohan777 commented 3 years ago

hi Piyush, I can change its UI and make it look like a slider as you have demonstrated and create a new UI element then it will be available in the Schedule actions.

manmohan777 commented 3 years ago

Screenshot_1604991929 this is the changed ui

manmohan777 commented 3 years ago

Screenshot_1605093630 and in schedule section color selector looks like this

shahpiyushv commented 3 years ago

@manmohan777 this looks good now. I will have someone review this. Meanwhile, can you please squash your 11 commits into 1?

shahpiyushv commented 3 years ago

@manmohan777 , thanks for the contribution. This has now been merged.