search

espressif / esp-rainmaker

ESP RainMaker Agent for firmware development
Apache License 2.0
433 stars 146 forks source link

Power metering (MEGH-3343) #121

Open brainstorm opened 2 years ago

brainstorm commented 2 years ago

Add power meter basic type and parameter, akin to temperature and #105 (humidity sensor).

More context over:

https://esp32.com/viewtopic.php?f=13&p=94595#p94595 https://github.com/brainstorm/yigedianqi-modbus/ https://github.com/brainstorm/yigedianqi-modbus/tree/esp-idf-rainmaker

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

shahpiyushv commented 2 years ago

@brainstorm , we have some reservations for this PR because ESP standard devices/params are typically meant for special handling either in our official phone apps or our 3rd party integrations like Alexa/GVA. Since there is no "power meter" category in Alexa/GVA and no immediate plan to add this in the phone apps either, we will need some more time to decide whether to merge this or not. I will also check internally to see if anyone had created any demo for Energy meters, and if some names were already chosen.

Meanwhile, since custom examples need not use standard types, I am hoping that this isn't blocking any of your projects.

brainstorm commented 2 years ago

Thanks @shahpiyushv, it doesn't block any of my projects, I was just going by the same moves as #105, didn't know about Alexa/GVA side of things since I don't own one nor I'm interested in them.

I guess that I could do the same thing just sticking with other custom type(s)? Then there's no need to go with has been done in this PR ;)

Feel free to close this PR it in any case if it doesn't serve yours or Espressif's needs. Cheers!

brainstorm commented 1 year ago

I wanted to contribute power metering cluster/attributes writing on the Matter spec after reading the relevant Matter 1.0 spec PDFs:

https://csa-iot.org/wp-content/uploads/2022/10/22-27349-001_Matter-1.0-Core-Specification76.pdf https://csa-iot.org/wp-content/uploads/2022/10/22-27351-001_Matter-1.0-Device-Library-Specification39.pdf https://csa-iot.org/wp-content/uploads/2022/10/22-27350-001_Matter-1.0-Application-Cluster-Specification15.pdf

But apparently it's a private repository so the public cannot make pull requests?: https://github.com/project-chip/connectedhomeip/issues/23339#issuecomment-1290736128

I guess that for now I'll have to go with the custom data model documented on esp-matter docs to match the power metering needs (fairly close to i.e the temperature sensor present in the 1.0 Matter spec anyway). Not ideal since I guess it'll complicate the Matter certification process later on, so please let me know if there's some avenue where I can contribute to the official spec without the pricey membership model/tiers from csa-iot.

dhrishi commented 1 year ago

@brainstorm I think it is not possible right now