espressif / esp-rainmaker

ESP RainMaker Agent for firmware development
Apache License 2.0
433 stars 146 forks source link

Added missing definitions for standard-types (MEGH-3516) #126

Closed sivar2311 closed 2 years ago

sivar2311 commented 2 years ago

Added missing standard-types from documentation.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

sivar2311 commented 2 years ago

Hello!

Are pull requests welcome? I opened one 11 days ago. Other PR are even older and they seem to be ignored. I only ask because another PR in arduino-esp32 repository depends on this PR.

shahpiyushv commented 2 years ago

Sorry for the delay. As you can see, several changes were going on in the repository. We will get this merged asap.

sivar2311 commented 2 years ago

Thanks for the quick reply! I am not that deep into this repository yet. I am more active on the Arduino side.

JohnMacrae commented 2 years ago

Nice work @sivar. Off topic but have you been successful in using OTA to a rainmaker device programmed via the Arduino IDE?

On Wed, 8 Jun 2022, 15:50 sivar2311, @.***> wrote:

Thanks for the quick reply! I am not that deep into this repository yet. I am more active on the Arduino side.

— Reply to this email directly, view it on GitHub https://github.com/espressif/esp-rainmaker/pull/126#issuecomment-1150023617, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHTIDJNVPWJJI4BMBGDTETVOCXKBANCNFSM5XGB566Q . You are receiving this because you are subscribed to this thread.Message ID: @.***>

sivar2311 commented 2 years ago

@JohnMacrae I haven't gotten that far yet. That's still on my to-do list. At the moment I'm trying to understand the whole system and simplify it with a few ideas of my own.

JohnMacrae commented 2 years ago

@sivar2311 Ok - good luck. N.B. This problem has been ignored but still exists for me https://github.com/espressif/arduino-esp32/issues/5420

shahpiyushv commented 2 years ago

@sivar2311 , can you once rebase your branch against master?

sivar2311 commented 2 years ago

@shahpiyushv Done :)