search

espressif / esp-rainmaker

ESP RainMaker Agent for firmware development
Apache License 2.0
432 stars 145 forks source link

gpio_button (MEGH-4093) #205

Open espressif2022 opened 1 year ago

espressif2022 commented 1 year ago

gpio_button is necessary, can it be removed？ Now component espressif/button is used, there is a conflict；

shahpiyushv commented 1 year ago

Older esp idfs do not use component manager by default and so, this component has been retained. It was renamed from button to gpio_button to prevent some conflicts in cmake dependency resolution. Can you elaborate what is the exact issue you are seeing? I believe your compilation must be finding 2 instances of the same APIs. Is that so?

espressif2022 commented 1 year ago

yes，compilation find 2 instances of the same APIs. I noticed that the function name has been changed here to prevent conflicts, but the newly added component espressif/button use the same name as you.

I'll ask the maintainer of button component if they can handle it. Thanks!