fix issue that out_xfer unintentionally returned by previous transmission (IEC-121)

espressif / esp-usb

Other

15 stars 9 forks source link

fix issue that out_xfer unintentionally returned by previous transmission (IEC-121) #40

Closed radiotommy closed 2 weeks ago

radiotommy commented 3 weeks ago

for timeout or any reason the semaphore could left untaken before the new transmission start. it causing the transmission pick up the previous actual_num_bytes and return failure because of incorrect number of bytes transferred.

tore-espressif commented 2 weeks ago

Thank you @radiotommy for the PR, I'll have a look ASAP

radiotommy commented 2 weeks ago

@tore-espressif The test run failure seems not caused by this change, is anyone looking into it?

tore-espressif commented 2 weeks ago

The test run failure seems not caused by this change, is anyone looking into it?

Yes, we got a regression few days ago that should not be caused by your changes.

We had a slightly different proposal to fix this issue. Let me check with my colleagues and I'll get back to you

tore-espressif commented 2 weeks ago