search

espressif / esp-who

Face detection and recognition framework
Other
1.64k stars 458 forks source link

Feature: use component manager (AIV-664) #280

Closed tore-espressif closed 7 months ago

tore-espressif commented 7 months ago

esp-sr, esp32-camera and mdns components are now fetched from ESP registry.

This is a first step for this repo to start using esp-bsp which can take care of all HW specific configuration.

I could not remove esp-dl too, because latest esp-dl does not support IDF >=5.1 https://github.com/espressif/esp-dl/pull/145

tore-espressif commented 7 months ago

@scgan @yehangyang Would you be interested in this change?

The overall goal for this repo would be to use esp-bsp as a 'Board abstraction layer' so you could focus only on esp-who changes

BlueSkyB commented 7 months ago

@tore-espressif
Because ESP-DL (components/esp dl/lib) does not distinguish between libraries of IDF4.4 and IDF5.0. And currently, it is not possible to confirm which interfaces in ESP-DL need to be distinguished in the short term. So changing esp-dl to fetched from ESP registry may cause compatibility issues.

tore-espressif commented 7 months ago

@BlueSkyB Is there any reason to provide separate esp-dl libs for IDF v5.0 and 4.4?

BlueSkyB commented 7 months ago

I am not sure about the specific reason. Perhaps scgan did not consider compatibility when porting IDF 5.0. Additionally, you can now use the latest master branch of ESP-WHO, which is based on IDF5.0. The new API of ESP-SR has been updated.

sun-xiangyu commented 7 months ago

@tore-espressif , Could you merge this feature on master branch? We plan to remove idfv5.0 branch and master branch will support idf (version > 5.0).

tore-espressif commented 7 months ago

@sun-xiangyu yes, I plan to update the PR this (or next) week and aim for the master branch. Thank you for having a look!

tore-espressif commented 7 months ago

@sun-xiangyu I updated the PR, but I haven't tested all the examples yet.

Also, I could not used esp-dl from component manager, because latest esp-dl does not support IDF >= 5.1 yet (tracked in https://github.com/espressif/esp-dl/pull/145)

tore-espressif commented 7 months ago

Examples work OK on esp32-s3-eye

sun-xiangyu commented 7 months ago

Thanks @tore-espressif for supporting component manager.

Also, I could not used esp-dl from component manager, because latest esp-dl does not support IDF >= 5.1 yet (tracked in espressif/esp-dl#145)

we will check why esp-dl do not support IDF > 5.1