search

espressif / esp-wolfssl

WolfSSL port for ESP-IDF & ESP8266_RTOS_SDK
38 stars 13 forks source link

Cleanup of the wolfSSL user_setting.h #12

Closed dgarske closed 3 years ago

dgarske commented 3 years ago

Disable the OPENSSL_ALL option by default.

dgarske commented 3 years ago

Related to: https://github.com/wolfSSL/wolfssl/issues/4241

dgarske commented 3 years ago

@mahavirj , any feedback on this PR?

AdityaHPatwardhan commented 3 years ago

@dgarske Thank you for the PR. sorry for the delayed turnaround. I just had one concern. Can you please enable the OPENSSL_EXTRA option in this case. As we use wolfSSL_SHA1 API internally with IDF (see link) and the example fails to compile if both OPENSSL_EXTRA and OPENSSL_ALL options are disabled.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

AdityaHPatwardhan commented 3 years ago

Thanks @dgarske for the changes. I have raised the MR in our internal codebase, it should be available publicly in a couple of days