espressif / esp32-arduino-lib-builder

146 stars 157 forks source link

Split cron jobs and move libs to releases #187

Closed lucasssvaz closed 1 month ago

lucasssvaz commented 3 months ago

Split the cron job using a matrix with preparations for release/v5.3

me-no-dev commented 3 months ago

Have a look at this file which should run in the first job to determine if the cron should even run. Yaml code for it was commented in the cron workflow

lucasssvaz commented 3 months ago

Isnt this already being done here ? https://github.com/espressif/esp32-arduino-lib-builder/blob/master/tools/install-esp-idf.sh#L54-L97

me-no-dev commented 3 months ago

it's the same thing in general, but what I point you to would be done before IDF is pulled and uses GITHUB API, instead of git, so it will happen sooner and faster

lucasssvaz commented 3 months ago

@me-no-dev PTAL if the libs generated here looks fine. Ill also open a PR with some changes to the IDF4 branch here so we can manually trigger it if needed.

Also, we might not be able to use environment variables in the manifest as it is not allowed by the IDF registry. Do you have any other ideas on how to do what we discussed ?

me-no-dev commented 3 months ago

Do you have any other ideas on how to do what we discussed ?

I suggest you ask in MM if there is any other way. That was the only thing I heard

lucasssvaz commented 3 months ago

@me-no-dev PTAL if the generated libs look correct. Specially the package JSON file. https://github.com/lucasssvaz/esp32-arduino-lib-builder/actions/runs/9786603646

me-no-dev commented 2 months ago

json looks good

me-no-dev commented 2 months ago

most of the things we discussed are yet to be implemented :)

lucasssvaz commented 2 months ago

@me-no-dev Moved to using releases. Tests in my forks appear to be working as expected

https://github.com/lucasssvaz/esp32-arduino-lib-builder/actions/runs/9966497424/job/27539203528 https://github.com/lucasssvaz/esp32-arduino-libs/releases/tag/idf-release_v5.1 https://github.com/lucasssvaz/arduino-esp32/pull/31

BTW, should we use IDF_CCACHE_ENABLE=1 by default ?