search

espressif / esptool-js

Javascript implementation of flasher tool for Espressif chips, running in web browser using WebSerial.
https://espressif.github.io/esptool-js/
Apache License 2.0
276 stars 108 forks source link

Live Demo no longer working #105

Closed QuirkyCort closed 1 year ago

QuirkyCort commented 1 year ago

In commit c34c8c7, index.ts was changed to use .textContent when reading the offset and file data. Since both the offset and file elements are html input elements with no textContent, the demo no longer works. It should be using .value and .data instead.

Relevant lines: https://github.com/espressif/esptool-js/blob/58df4cdb6f902c7b38dfaf787f212f9f8fb8028f/examples/typescript/src/index.ts#L279

https://github.com/espressif/esptool-js/blob/58df4cdb6f902c7b38dfaf787f212f9f8fb8028f/examples/typescript/src/index.ts#L290

RushikeshPatange commented 1 year ago

Yes, when clicking on the program button, nothing is happening due to the issue mentioned by @QuirkyCort in the live demo example. Could you please take a look at it, @brianignacio5? Thank you! 😄

brianignacio5 commented 1 year ago

Oh apologies for the issue! Will update asap !

sdrshnptl commented 10 months ago

Live demo not working again. Any thought why this might be broken? image

brianignacio5 commented 10 months ago

Sorry for late reply. Made a fix here: https://github.com/espressif/esptool-js/pull/121

@sdrshnptl