update buffer ref in esploader

espressif / esptool-js

Javascript implementation of flasher tool for Espressif chips, running in web browser using WebSerial.

https://espressif.github.io/esptool-js/

Apache License 2.0

276 stars 108 forks source link

update buffer ref in esploader #127

Closed brianignacio5 closed 8 months ago

brianignacio5 commented 8 months ago

Was using a node reference in esploader to Buffer class instead of the buffer npm module added.

This update should add reference to node_modules/buffer instead.

Fix #125

github-actions[bot] commented 8 months ago

Download the artifacts for this pull request:

esptool-js-0.4.0.tgz.zip

RushikeshPatange commented 8 months ago

Thank you @brianignacio5 ! , for fixing this issue. I've successfully tested the fix for the newly added C2, on my local environment.

balloob commented 7 months ago

I hadn't seen the introduction on Buffer because it was hidden inside the JSDoc API, which I assumed was only adding documentation.

The buffer npm package is 2000 lines of JavaScript for a total of 26kB. Previously, esptool-js worked without it. Can you explain why we need to add this dependency?

Size and impact of bundling buffer npm package (via bundlephobia)