search

espressif / esptool-js

Javascript implementation of flasher tool for Espressif chips, running in web browser using WebSerial.
https://espressif.github.io/esptool-js/
Apache License 2.0
251 stars 101 forks source link

Support Chrome on Android with web-serial-polyfill in the Example Pages. #144

Closed Lan-Hekary closed 1 month ago

Lan-Hekary commented 1 month ago

Add Google Chrome on Android version 61 or later via the web-serial-polyfill compatibility layer.

I tested it and it works as expected with Chrome on Android Phones and Tablets.

brianignacio5 commented 1 month ago

LGTM thanks for your contribution

Lan-Hekary commented 3 weeks ago

Thanks @brianignacio5 , Thanks for the merge, it's working as expected. I Just realized that I can use the package from the CDN(JSDeliver or unpkg) instead of putting it in the package.json file and bundle it with the site assets. I don't know if it is the right way to import external modules (Import from CDN or Bulid and bundle it with the site), I'd love to hear you opinion on the matter. If you want me to make this change too, I can make it It's more aligned with the current codebase and won't affect the functionality.