Closed igrr closed 1 year ago
Could we have a new release once this is merged? 🙏
🎉
Would you have time for a release this week?
@igrr last time I'll ask, but could we get a release with this fix? Now that the repo has been migrated to TypeScript, we can no longer point our dependency at a git commit
@balloob I am sorry for the delay! We have talked with @brianignacio5 about preparing the new release, but it seems like there is some issue in the release workflow that needs to be fixed, and neither of us has had time to look into this yet, unfortunately!
@balloob release is done :-)
Block write timeout is generally determined by the time it takes to erase and write the data into flash. Since that time is proportional to the amount of uncompressed data written, we need to keep track of the number of bytes each chunk is decompressed into.
Re-enable the commented out code block, based on a suggestion (from Mark Adler, no less!) in https://stackoverflow.com/a/73096372.
Testing
I've tested this by flashing a 2 MB sized empty SPIFFS image.
Without the fix, flashing times out.
With the fix, the timeout seems to be correctly calculated based on the uncompressed chunk size. With some debug logging added: