espressif / esptool-js

Javascript implementation of flasher tool for Espressif chips, running in web browser using WebSerial.
https://espressif.github.io/esptool-js/
Apache License 2.0
288 stars 108 forks source link

Initial support for the ESP32-C6-DevKitC-1 #92

Closed linkedupbits closed 1 year ago

linkedupbits commented 1 year ago

This PR adds support for the ESP32-C6-DevKitC-1. It has been tested uploading the binary outputs from esp-idf

linkedupbits commented 1 year ago

I have also tested this using a local esphome-web-tools dev container, after building a esptool-js-0.2.1.tgz and placing it locally. The local esphome-web-tools is then able to successfully connect to the C6 via the local COM port and show trace logs. (Uploading a base ESPHome image is not working yet)

linkedupbits commented 1 year ago

@balloob - with the reverted line endings, is there anything outstanding on this PR?

balloob commented 1 year ago

I'm sorry, I just hang around this repo as we rely on it downstream for ESP Web Tools. I am not able to review/merge PRs.

linkedupbits commented 1 year ago

I'm sorry, I just hang around this repo as we rely on it downstream for ESP Web Tools. I am not able to review/merge PRs.

Makes sense - the reason I am trying to get this merged is for eventual ESPHome support.

If you don’t mind, to incorporate into a dev ESPHome:

is there a guide for a setting up a “fully local “ dev stack, to make integrating new chipsets easier for new starters?

linkedupbits commented 1 year ago

@brianignacio5 are you able to review this PR?

brianignacio5 commented 1 year ago

Could you please check the lint errors ? Just run npm run lint locally.

linkedupbits commented 1 year ago

npm run lint

@brianignacio5 : local lint output (after 8ec78d5 and 23242c1):

npm run lint

> esptool-js@0.2.2 lint
> eslint . --ext .ts

/home/stephen/esp/linkedupbits/esptool-js/src/targets/esp32c3.ts
  70:34  warning  'loader' is defined but never used  @typescript-eslint/no-unused-vars
  74:33  warning  'loader' is defined but never used  @typescript-eslint/no-unused-vars

/home/stephen/esp/linkedupbits/esptool-js/src/targets/esp32c6.ts
  70:34  warning  'loader' is defined but never used  @typescript-eslint/no-unused-vars
  74:33  warning  'loader' is defined but never used  @typescript-eslint/no-unused-vars

/home/stephen/esp/linkedupbits/esptool-js/src/targets/esp32s2.ts
  78:33  warning  'loader' is defined but never used  @typescript-eslint/no-unused-vars

/home/stephen/esp/linkedupbits/esptool-js/src/targets/esp32s3.ts
  43:37  warning  'loader' is defined but never used  @typescript-eslint/no-unused-vars
  46:34  warning  'loader' is defined but never used  @typescript-eslint/no-unused-vars
  49:33  warning  'loader' is defined but never used  @typescript-eslint/no-unused-vars

✖ 8 problems (0 errors, 8 warnings)

Should be better now.

brianignacio5 commented 1 year ago

LGTM !