Closed kloczek closed 1 year ago
And after add those four files to --ignore list
Hi @kloczek,
The first four scripts (the ones you added to --ignore list) are not meant to be run directly (more info here).
Nevertheless, esptool.py
project tests were not written with pytest
in mind.
We are taking a lo-fi approach of running the test python scripts one by one, see here. Most of the test are also meant to be run with real hardware connected. Just running pytest
will therefore not work out of the box.
Nevertheless,
esptool.py
project tests were not written withpytest
in mind.
Nevertheless I would try gentrly encorage you to try to have look closer on pytest as it is de facto standard test suite framework fo +8/9 of all modules 😄
I'm not hiding that as I'm working on some Linux/Solaris distro (now with +940 modules packaged) I'm trying to standardise all tests around pytest because it allow not only test generated packages but allow as well use build procedure to evaluate/audit all packaged python code.
None of other approaches to python modules testing provides such useful platform.
If for example pytest would be useable to it is easy to install for example 'pytest-blackin build env and by execute 'pytest --black
to have integrated with regular test suite black
module tests. The same is with many, many other pytest extensions allowing keep python code better.
Nevertheless as I found some units working I've added all failing units to --deselect list to have now some baseline for regression tests between versions. In other words I have now kind of solution but it would be good to improve pytest usability 😋
Here is pytest output for exptool 4.3 (new units started failing esptool-pytest.txt
Operating System
Linux/x86_64
Version
latest master
Python Version
3.8.13
Full Esptool Command Line that Was Run
N/A
Esptool Output
What is the Expected Behaviour?
pytest should pass without errors.
More Information
I'm trying to package your module as an rpm package. So I'm using the typical PEP517 based build, install and test cycle used on building packages from non-root account.
python3 -sBm build -w --no-isolation
build
with--no-isolation
I'm using during all processes only locally installed modulesHere is pytest output:
Other Steps to Reproduce
No response