search

espressif / esptool

Espressif SoC serial bootloader utility
https://docs.espressif.com/projects/esptool
GNU General Public License v2.0
5.6k stars 1.39k forks source link

Don't use self-hosted builders (ESPTOOL-882) #992

Open floitsch opened 4 months ago

floitsch commented 4 months ago

Is your feature request related to a problem?

The GitHub actions use a self-hosted builder which makes forking the repository harder.

Describe the solution you'd like

You could run the build-steps on GitHub runners in a virtual machine.

Our implementation is here: https://github.com/toitlang/esptool/blob/b2d74c9958b1e6e858b655fbc1b6e28d3b3ca9be/.github/workflows/build.yml

The biggest disadvantage is that the building is much slower.

Describe alternatives you've considered

No response

Additional context

No response

radimkarnis commented 4 months ago

Hi @floitsch, thanks for the request and pointers to your implementation!

I agree forking the repo should be easier. We will look into this!

floitsch commented 4 months ago

I just noticed that the linked build.yml script had an LGPL license. This is now changed to BSD-0: https://github.com/toitlang/esptool/blob/b2d74c9958b1e6e858b655fbc1b6e28d3b3ca9be/.github/workflows/build.yml

FlorianHeigl commented 2 months ago

it would make more sense if you'd title this "also allow running on github builders". a project should be able to chose its infra as the project seems fit, and should be free to use the platforms' features as they seem fit. (they should also document how to get it to a ci-buildable/forkable state to avoid shooting their own leg) it sucks as much as it is that the build instructions boil down to 'disect the github ci files'