search

espressif / idf-component-manager

Tool for installing ESP-IDF components
https://components.espressif.com/
Apache License 2.0
42 stars 15 forks source link

fix(docs): Require field must be in quotes (PACMAN-791) #49

Closed tore-espressif closed 4 months ago

tore-espressif commented 5 months ago

@magicarm22 Please check this update

I had to place "no" in quotes so it works on my Windows machine and idf-component-manager 1.4.1

github-actions[bot] commented 5 months ago
Messages
:book: Good Job! All checks are passing!

👋 Welcome tore-espressif, thank you for your first contribution to espressif/idf-component-manager project!

📘 Please check project Contributions Guide of the project for the contribution checklist, information regarding code and documentation style, testing and other topics.

Pull request review and merge process you can expect

We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

  1. An internal issue has been created for the PR, we assign it to the relevant engineer
  2. They review the PR and either approve it or ask you for changes or clarifications
  3. Once the Github PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing
    • At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
  4. If the change is approved and passes the tests it is merged into the default branch

Generated by :no_entry_sign: dangerJS against 7f36ea686e81200817bd92a2a88ad6e34227f5f4

magicarm22 commented 5 months ago

@tore-espressif Thanks for your contribution, LGTM!

kumekay commented 5 months ago

@magicarm22 I remember we handled the Norway problem while designing this feature.

@tore-espressif How exactly it breaks for you? The behavior should be the same for both no - parsed as boolean false and "no" - string "no"

tore-espressif commented 4 months ago

@kumekay Here is the error log:

 ERROR: A problem was found in the manifest file
  C:/github_repos/esp-bsp/examples/display/main\idf_component.yml:

  Unknown boolean field "require" in the manifest file that may affect build
  result

  SUGGESTION: This component may be using a newer version of the component
  manager.

  You can try to update the component manager by running:

      C:\Espressif\python_env\idf5.3_py3.8_env\Scripts\python.exe -m pip install --upgrade idf-component-manager

Call Stack (most recent call first):
  C:/esp_repos/esp-idf/master/tools/cmake/project.cmake:710 (idf_build_process)
  CMakeLists.txt:9 (project)

This is the manifest

description: BSP Display example

dependencies:
  esp_wrover_kit:
    version: "^1.0.0"
    require: no
    override_path: "../../../bsp/esp_wrover_kit"
kumekay commented 4 months ago

@tore-espressif Thank you for the log, no without quotes should be supported, we will fix it

kumekay commented 4 months ago

@tore-espressif We fixed support for no without quotes in https://github.com/espressif/idf-component-manager/commit/6ae82dfbc9d90cc613e16b7b1109091a6ea58955 and v1.5.2