search

espressif / idf-component-manager

Tool for installing ESP-IDF components
https://components.espressif.com/
Apache License 2.0
44 stars 16 forks source link

urllib3 2.2.0, requests-file 2.0.0 (PACMAN-794) #50

Closed jiapei100 closed 7 months ago

jiapei100 commented 8 months ago

Please describe your proposed PR and what it contains.

Impact

Please describe the impact of your PR and its function.

Related links

Please provide links to related issue, PRs etc.

Checklist

  1. [ ] Please provide the specific and clear title of the PR describing the change (eg. „Fix support for python versions >3.136“)
  2. [ ] Please provide related links (eg. Issue, related repository, etc...)

This entire section above can be deleted if all items are checked.

github-actions[bot] commented 8 months ago
Warnings
:warning: The PR description looks very brief, please check if more details can be added.

👋 Welcome jiapei100, thank you for your first contribution to espressif/idf-component-manager project!

📘 Please check project Contributions Guide of the project for the contribution checklist, information regarding code and documentation style, testing and other topics.

Pull request review and merge process you can expect

We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

  1. An internal issue has been created for the PR, we assign it to the relevant engineer
  2. They review the PR and either approve it or ask you for changes or clarifications
  3. Once the Github PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing
    • At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
  4. If the change is approved and passes the tests it is merged into the default branch

:repeat: You can re-run automatic PR checks by retrying the DangerJS action

:warning: Deprecation Notice: This GitHub action is scheduled for removal in March 2024. We recommend migrating to the latest version available in the shared-github-danger project.

Generated by :no_entry_sign: dangerJS against 4dd9bdaed03f71829b5f3f46c3e4b5ee13d2f74d

dobairoland commented 7 months ago

I don't think this is a solution for your problem outlined in https://github.com/espressif/esp-idf/issues/13102. It is just a workaround for you and probably cannot be accepted here. I'm not a component manager developer but I think those package version limits are there for a reason.

kumekay commented 7 months ago

@jiapei100 Thank you for contribution,

Unfortunately versions are locked due to issues with other packages, and this change cannot be accepted right now. We are going to drop support for older pythons in the coming release next month and update the dependencies.