Closed alirana01 closed 1 month ago
The recent updates streamline the tool activation process within the system by replacing the previous ToolsInstallationJob
mechanism with a direct instantiation of IDFToolSet
. This change simplifies the control flow, enhances code clarity, and maintains robust error handling. Additionally, unnecessary import statements have been removed from ExportIDFTools.java
, further optimizing the codebase for better maintainability.
File | Change Summary |
---|---|
.../InitializeToolsStartup.java |
Refactored to remove ToolsInstallationJob and listener, directly using IDFToolSet . Defined IDF_TOOLS_PATH_KEY as a constant. |
.../ExportIDFTools.java |
Removed unnecessary import statements for Platform and IDFCorePreferenceConstants . |
In a burrow deep, we dance with glee,
Tools activated, oh so free!
Hopping through code, with joy we play,
Simplified paths pave our way.
A bunny's cheer for changes bright,
Making our tools shine with light! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Description
Updated to improve the offline installer behavior with IDE, now using the installed tools in the offline installer instead of creating a new set. Improved handling of IDF_TOOLS_PATH to ensure that
Fixes # (IEP-1275)
Type of change
Please delete options that are not relevant.
How has this been tested?
Please verify this with offline installer's esp_idf.json file to make sure that the tools are not installed but are rather used from the offline installer's directory. Everything else including the ESP-IDF Manager should stay as is if new bugs are found please report them here and create a new ticket for them.
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit
New Features
Refactor
Chores