Closed alirana01 closed 1 month ago
The changes introduce a new static method closeWelcomePage
in the IDFUtil
class, allowing for the programmatic closure of the welcome page in the Eclipse IDE. This new functionality is utilized in the NewProjectHandler
and ManageEspIdfVersionsHandler
classes, simplifying their control flow by replacing nested checks with direct calls to closeWelcomePage
. These modifications enhance user interaction with the IDE by ensuring the welcome page is closed when appropriate.
Files | Change Summary |
---|---|
bundles/com.espressif.idf.core/src/com/espressif/idf/core/util/IDFUtil.java |
Added public static void closeWelcomePage(IWorkbenchWindow activeww) method to manage welcome page visibility. |
bundles/com.espressif.idf.ui/src/com/espressif/idf/ui/handlers/NewProjectHandler.java |
Integrated a call to IDFUtil.closeWelcomePage() in the execute method to close the welcome page when starting a new project. |
bundles/com.espressif.idf.ui/src/com/espressif/idf/ui/tools/ManageEspIdfVersionsHandler.java |
Refactored launchEditor method to utilize IDFUtil.closeWelcomePage(activeww) , simplifying the logic for closing the welcome page. |
🐰 In the realm of code where rabbits hop,
A welcome page closes, no need for a stop.
With a flick of a method, the clutter's all gone,
New projects now flourish, let the coding go on!
Hooray for the changes, so bright and so neat,
In the garden of software, we dance on our feet! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@AndriiFilippov Please review
@alirana01 @kolipakakondal hi ! Isn't it the same https://github.com/espressif/idf-eclipse-plugin/pull/1005 ? We already have this feature implemented
@alirana01 @kolipakakondal hi ! Isn't it the same #1005 ? We already have this feature implemented
This is about closing the welcome page when someone tries to create a new project, while this pull request is about closing the welcome page when you open the ESP-IDF Managers view. Most likely, these are two actions users perform when they first open the IDE.
@alirana01 @kolipakakondal hi ! Isn't it the same #1005 ? We already have this feature implemented
This is about closing the welcome page when someone tries to create a new project, while this pull request is about closing the welcome page when you open the ESP-IDF Managers view. Most likely, these are two actions users perform when they first open the IDE.
doesn't matter because both actions lead to "ESP-IDF: Manager". I have just checked the master branch - everything works how it should.
@alirana01 hi !
Tested under: OS - Windows 11 / MacOS
Do see the "Welcome" page closes if open "New Espressif IDE Project" ✅
LGTM 👍
Description
Close the welcome page if opened when new project is created
Fixes # (IEP-1090)
Type of change
Please delete options that are not relevant.
How has this been tested?
Keep the welcome page opened after installing tools and try creating new project. Welcome page should be closed
Test Configuration:
Checklist
Summary by CodeRabbit
New Features
Refactor
ManageEspIdfVersionsHandler
by simplifying the logic for managing the welcome page visibility.