search

espressif / idf-eclipse-plugin

Espressif-IDE (based on Eclipse CDT) for ESP-IDF CMake based projects 4.x and above
Eclipse Public License 2.0
295 stars 115 forks source link

IEP-1026: Pressing "Stop" button during build process leads to error. #885

Closed sigmaaa closed 5 months ago

sigmaaa commented 5 months ago

Description

Pressing Stop now terminates building processes. Also did a small refactoring, which improves build time for DFU.

Fixes # (IEP-1026)

Type of change

Please delete options that are not relevant.

How has this been tested?

Test 1: build -> Stop Test 2: select DFU -> Build -> Stop

Test Configuration:

Dependent components impacted by this PR:

Checklist

Summary by CodeRabbit

coderabbitai[bot] commented 5 months ago

Walkthrough

The updates pertain to the Espressif IDF Eclipse plugin, with a focus on enhancing dependency management, streamlining the build configuration process, and refining the DFU (Device Firmware Update) command utility. These refinements include enforcing a version requirement for a dependent bundle, cleaning up the code by removing unused imports, reorganizing code for clarity, and altering how build and flash commands are handled.

Changes

File Path Change Summary
.../MANIFEST.MF
.../DfuCommandsUtil.java		 Added version requirement for org.eclipse.cdt.core bundle.
Code cleanup, logic adjustments, and method refactoring in DFU-related classes.
.../IDFBuildConfiguration.java Code cleanup, reordering, and build process adjustments.

🐇✨ In the realm of code, we hop and refine, Cleaning up, enhancing, making it shine. With each careful tweak and artful adjust, We craft the bytes that earn your trust. 🌟

  (\(\  
  ( -.-)  
  o_(")(")

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
AndriiFilippov commented 5 months ago

@sigmaaa hi !

Tested under: OS - Windows 10 ESP-IDF: v5.1.2

1) Build -> Stop -> Build -> Flash -> Monitor 👍 2) Build -> Stop -> Close Project -> Open Project -> Build -> Flash -> Monitor 👍 3) Build -> Stop -> Close Eclipse -> Open Eclipse -> Build -> Flash -> Monitor 👍 4) Build -> Stop -> Restart -> Build -> Flash - Monitor 👍 5) select DFU -> Build -> Stop -> Build -> Flash - Monitor 👍 6) Custom Build Folder -> Build -> Stop -> Build -> Flash - Monitor 👍 7) New Project -> click "Run" -> Stop -> can't stop build process ❌

sigmaaa commented 5 months ago

Hi @AndriiFilippov, It was fixed with the last commit. @alirana01, @kolipakakondal PTAL at the last commit. I had to add a workaround and custom handler, which terminates the build process, which is part of the Launching job. To avoid handler conflicts, I created a context with id com.espressif.idf.ui.espLaunchScope and added a condition for activating a custom handler.

AndriiFilippov commented 5 months ago

@sigmaaa hi !

Retested all scenarios. LGTM 👍