search

espressif / idf-eclipse-plugin

Espressif-IDE (based on Eclipse CDT) for ESP-IDF CMake based projects 4.x and above
Eclipse Public License 2.0
295 stars 115 forks source link

Abort build process in presence of errors (IEP-1180) #912

Closed LemonBoy closed 3 months ago

LemonBoy commented 3 months ago

When the build runner runs Make/Ninja and correctly detects the presence of one or more errors the build process should be aborted earlier.

At the moment the code is blindly continuing as if the binary was successfully build and goes on calling idf_size.py on a stale map file and, what's worse, dumps the output of idf_size.py in the console window, hiding the red lines pointing to the error.

sigmaaa commented 3 months ago

Hi @LemonBoy,

that's a good point! Thank you for reporting this.