search

espressif / idf-eclipse-plugin

Espressif-IDE (based on Eclipse CDT) for ESP-IDF CMake based projects 4.x and above
Eclipse Public License 2.0
295 stars 115 forks source link

fix: fixing duplicates configs when creating new project #918

Closed sigmaaa closed 2 months ago

sigmaaa commented 3 months ago

Description

Steps to reproduce for me:

  1. create a new default project "test"
  2. delete a project without deleting all related configuration
  3. create a default "test" project again
  4. click edit on the configuration
  5. The name of configuration is not "test" as supposed to be and a lot of duplicates are created

The problem happens because the default launch config is removed during project deletion and then we can't find it in a map always creating duplicates of the original one. Fixed by looking for existing config via launch manager first before creating a new configuration. Fixes # (IEP-1187)

Type of change

Please delete options that are not relevant.

How has this been tested?

  1. create a new default project "test"
  2. delete a project without deleting all related configuration
  3. create a default "test" project again
  4. click edit on the configuration
  5. make sure no duplicates were created.

Test Configuration:

Dependent components impacted by this PR:

Checklist

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The changes encompass improvements to the ESP-IDF tooling in Eclipse, focusing on enhancing usability and efficiency. These updates aim to streamline the development workflow by refining the launch configuration process for readability and performance, introducing methods to find existing and debug launch configurations, and updating project handling logic to facilitate easier management and debugging of IoT projects.

Changes

File Path Changes
.../idf.core/.../LaunchConfigFinder.java
.../idf.core.test/.../LaunchConfigFinderTest.java		 - Introduced LaunchConfigFinder class for finding launch configurations based on descriptors and identifiers.
- Added test cases for LaunchConfigFinder class to validate configuration retrieval methods.
.../idf.launch.serial.core/.../IDFCoreLaunchConfigProvider.java - Refactored getLaunchConfiguration method for efficiency and readability.
- Added findExistingLaunchConfiguration method.
.../idf.ui/.../NewIDFProjectWizard.java - Added import for LaunchConfigFinder.
- Replaced DisposeListener with lambda expression.
- Updated logic in performFinish method for debug configurations.

Poem

Among the code's branches, a rabbit did play,
🐇 Refactoring with joy, making improvements all day.
🌱 Efficiency bloomed, like flowers in the spring,
🚀 Debug configurations, a useful thing.
"Streamline the workflow," the rabbit did sing,
🎉 IoT development made easier with each swing.
🌟 "Our work here is done," it proclaimed with a grin!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
kolipakakondal commented 3 months ago

@AndriiFilippov Could you please check this?

AndriiFilippov commented 3 months ago

@sigmaaa hi !

Tested under: OS - Windows 10 ESP-IDF: v5.1.2

Followed steps from description -> don't see duplicates are created, config name stay same. able to build - debug.

image

LGTM 👍