Closed sigmaaa closed 2 months ago
This update to the ESPToolChainManager.java
enhances the toolchain management within the Eclipse plugin for ESP-IDF by ensuring that the getDirectories
method now intelligently filters out and omits any non-existent paths from its output. This refinement aims to streamline the build process by avoiding potential errors related to invalid directory paths.
File Path | Change Summary |
---|---|
.../idf/core/toolchain/ESPToolChainManager.java |
Updated getDirectories to exclude non-existent paths from results |
In a burrow, deep and wide,
A coderabbit does reside.
With a hop, skip, and a leap,
Cleaned the paths, no longer steep.
🌟 "No more errors," it declared,
"For your builds, I've greatly cared!"
🐰💻✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@sigmaaa hi !
Tested under:
OS - Windows 10 ESP-IDF: v5.2
Nice ! We have gotten rid of unnecessary clutter in the console. Before, when launching the IDE, I have almost had a heart attack from the amount of this red spam.
Before:
Your PR:
LGTM 👍
Description
During the first IDE startup, we are trying to initialize toolchains from the PATH. If Path contains paths that don't exist anymore we will get an exception
Fixes # (IEP-1194
Type of change
Please delete options that are not relevant.
How has this been tested?
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit