Closed Jacques-Zhao closed 1 year ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
@Jacques-zhao Hi, well done and you have done a great job!
The one thing I would like to ask. If there is an additional string descriptor logic has been added, probably it is better to do that with a specific function. For example, "tusb_set_extra_str_descritpor" or "tusb_set_str_descriptor", which should have been added as an independent function from "tusb_set_descriptor".
That can help us to achieve following things:
What do you think?
Anyway, thanks for the changes. Probably, @tore-espressif can suggest more things here.
Always ready to a discuss, so feel free to do that. RJ
@roma-jam @Jacques-zhao I started refactoring the string descriptors handling too :)
I'll review this (or push my code for comparison) soon
Hi @Jacques-zhao @roma-jam
I wanted to refactor ithe interanl string descriptor handling for a while so now it is ready in https://github.com/espressif/idf-extra-components/pull/134 PTAL
Looking at this PR, I have a couple of questions:
esp_tinyusb
as stableI will resubmit a new version based on Tomas PR(https://github.com/espressif/idf-extra-components/pull/134)
Added support for USB NCM class. This MR relies on a tinyusb MR. The USB NCM example will be placed in the examples/peripherals/usb/device/tusb_ncm directory under esp-idf repository.