esp_tinyusb: String descriptor handling

espressif / idf-extra-components

Additional components for ESP-IDF, maintained by Espressif

152 stars 93 forks source link

esp_tinyusb: String descriptor handling #134

Closed tore-espressif closed 1 year ago

tore-espressif commented 1 year ago

There are following changes:

Commit 816c3ad7d036e6563953cce840ef5c8e039ddd61

Cleanup TinyUSB string descriptors handling. Remove unused code. Add length check to arguments passed to tinyusb_driver_install
Add private option to modify string descriptors

Commit 770d9a9204e7a7c5936de5c61f99b2845cc46f89

Use latest tinyusb v0.14.2
Update Kconfig and tusb_config.h for new feature (Bluetooth, NET, DFU)

~### Commit 97a108e686134149f250366e0fdd3703e7c80afc~ ~ Proposal of MAC string handling for NET class~ ~ Will be dropped~

Related #133

I can split the PR into 2, if it is easier to review.

github-actions[bot] commented 1 year ago

Unit Test Results

  11 files   11 suites 14m 39s :stopwatch:   16 tests   16 :heavy_check_mark: 0 :zzz: 0 :x: 162 runs 162 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 79f35c9b.

:recycle: This comment has been updated with latest results.

tore-espressif commented 1 year ago

@roma-jam @esp-saurabhbansal @Jacques-zhao PTAL

esp-saurabhbansal commented 1 year ago

@tore-espressif I have left one comment, please check.

tore-espressif commented 1 year ago

@tore-espressif Left a couple of nitpicks.

One more nitpick. Is the WIP: Draft of MAC string handling commit still WIP? Do we need to update the commit message's name.

LGTM otherwise

Thank you for the review @Dazza0 !

I plan to drop that commit before merging. One of the reasons for the PR is to prepare esp_tinyusb for new network drivers. I added that^ commit to show the reviewers how I imagined the upper layer MAC string hadnling