espressif / idf-extra-components

Additional components for ESP-IDF, maintained by Espressif
147 stars 89 forks source link

USB: CDC-ACM enhacements #144

Closed tore-espressif closed 1 year ago

tore-espressif commented 1 year ago

Change description

Change log

Breaking change

The last point^ is unfortunately a breaking change. Some cellular modems in esp_modem need it.

Additional info

github-actions[bot] commented 1 year ago

Unit Test Results

  11 files  ±0    11 suites  ±0   14m 44s :stopwatch: +5s   16 tests ±0    16 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  162 runs  ±0  162 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 99ae92be. ± Comparison against base commit a66d5e52.

:recycle: This comment has been updated with latest results.

tore-espressif commented 1 year ago

@roma-jam @esp-saurabhbansal PTAL! @Dazza0 Could you please check the part where I'm modifying the 'const data_buffer' in usb_transfer_t? It is a very handy feature to have zero-copy receive (IN) path

cc @david-cermak

Dazza0 commented 1 year ago

@tore-espressif Whoops, my bad (didn't review it in time). W.r.t to modifying the const buffer, IMO it should be OK for now. But the cleaner solution would be to support that officially via the USB Host interface (see IDF-6932), so we might need to update the CDC driver again once that is supported.

tore-espressif commented 1 year ago

@Dazza0 no problem. I was impatient and decided to take the odds and live with the consequences :D I can yank the version if it causes problems