search

espressif / idf-extra-components

Additional components for ESP-IDF, maintained by Espressif
147 stars 89 forks source link

usb: Implement new usbd MSC Class in esp_tinyusb #151

Closed esp-saurabhbansal closed 1 year ago

esp-saurabhbansal commented 1 year ago
  1. Add usbd MSC Class for accessing storage like SPI Flash or sd-card.
  2. Modify TCs for this change.
esp-saurabhbansal commented 1 year ago

@igrr Thanks for the review comments. @tore-espressif @roma-jam @Dazza0 PTAL. I will soon be raising MR for usb device msc example code.

esp-saurabhbansal commented 1 year ago

@igrr Thanks for the review comments. Please check if you agree. @tore-espressif @roma-jam @Dazza0 PTAL.

tore-espressif commented 1 year ago

@esp-saurabhbansal We have USB MSC Host test implemented, where we also use mock USB Device https://github.com/espressif/idf-extra-components/blob/master/usb/usb_host_msc/test/msc_device.c

Could you rewrite the mock device so it uses your MSC device layer? We could see how the API is meant to be used, whether it compiles and whether it works with our MSC Host driver (the test is run on real HW, if you are interested you can have a look here)

esp-saurabhbansal commented 1 year ago

@tore-espressif I came to know that currently, there is no API (callback) that can be used to detect sdcard disconnect. I have informed the owner of sdmmc driver module owner about this requirement. In future, if such API or method is implemented, we can update our msc driver accordingly.

tore-espressif commented 1 year ago

Could you rewrite the mock device so it uses your MSC device layer?

@esp-saurabhbansal any news about the tests?

esp-saurabhbansal commented 1 year ago

Could you rewrite the mock device so it uses your MSC device layer?

@esp-saurabhbansal any news about the tests?

@tore-espressif All the TCs are passing now. There is a separate commit for TC modification. Mock device implementation is modified. Plus, there are few changes which are done to make TCs in pipeline pass for different targets. Please check.