espressif / idf-extra-components

Additional components for ESP-IDF, maintained by Espressif
152 stars 93 forks source link

esp_tinyusb: add USB device class NCM (IEC-17) #154

Closed Jacques-Zhao closed 1 year ago

Jacques-Zhao commented 1 year ago

Added support for NCM class, and the corresponding example can be found in IDF MR: 22232

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Jacques-Zhao commented 1 year ago

@tore-espressif @roma-jam PTAL, See this example(MR: 22232) for how to use it

tore-espressif commented 1 year ago

Hello @Jacques-Zhao thank you very much for your contribution! I have 2 general topics to discuss:

  1. I can see that there are few TODOs in the code. Could you please share your plans or design documents about what should be implemented before this PR is merged?
  2. Are there any fields in the NCM descriptor that the user might want to change? (usb_descriptors.c, line 190)
tore-espressif commented 1 year ago

@david-cermak PTAL

Jacques-Zhao commented 1 year ago

@david-cermak Considering that you will be submitting a new similar PR, can I close this?

david-cermak commented 1 year ago

Considering that you will be submitting a new similar PR, can I close this?

Yes please. I'll create a new PR based on your commit. Thanks!