search

espressif / idf-extra-components

Additional components for ESP-IDF, maintained by Espressif
147 stars 89 forks source link

check components in PRs #220

Closed igrr closed 11 months ago

igrr commented 1 year ago

Verify components in PRs by running the upload action with --dry-run argument (based on https://github.com/espressif/upload-components-ci-action/pull/12)

Will hopefully prevent issues like https://github.com/espressif/idf-extra-components/pull/219 and https://github.com/espressif/idf-extra-components/pull/161.

igrr commented 1 year ago

Unfortunately looks like this doesn't work in general, because upload --dry-run still requires a valid API token, which isn't available in a fork: https://github.com/espressif/idf-extra-components/actions/runs/5693133175/job/15431540414?pr=220

igrr commented 1 year ago

Looks like this will be solved by https://github.com/espressif/idf-component-manager/commit/488bf90cd10051f9be5ef37a64e9f11b2d2d89fd.

igrr commented 12 months ago

dry-run is not noticing the lack of the license file, will probably need a fix on idf-component-manager side.

igrr commented 11 months ago

Okay, looks like the dry-run is able to detect some of the issues:

So i think this PR is ready. @tore-espressif please take a look again!