espressif / idf-extra-components

Additional components for ESP-IDF, maintained by Espressif
147 stars 89 forks source link

refactor(led_strip): Remove the hack code (IEC-37) #222

Closed Kainarx closed 1 year ago

Kainarx commented 1 year ago

Since the spi driver has fixed the idle level of MOSI. Remove the operation which controls the register.

Checklist

Change description

Please describe your change here

suda-morris commented 1 year ago

@Kainarx Thanks for the cleanup. For some reason, we need to delay this PR until the SPI driver fix (https://github.com/espressif/esp-idf/commit/8f5851d0646cf7fbccc66929b2e307f0e4b438e3) got merged into esp-idf 's release/v5.1 branch.

Edit: Now the fix got backport to the release/v5.1 branch: https://github.com/espressif/esp-idf/commit/77b74ab0919ef185682e22a2fbef8bb1a21262a6