espressif / idf-extra-components

Additional components for ESP-IDF, maintained by Espressif

143 stars 86 forks source link

Relax IDF version dependency till v4.0 (IEC-67) #261

Closed vikramdattu closed 7 months ago

vikramdattu commented 10 months ago

qrcode component is mostly independent and can also be used with IDF v4.0 Relaxing the version dependency on IDF makes the component usable for projects with older IDFs.

Checklist

[x] Component contains License
[x] Component contains README.md
[x] Component contains idf_component.yml file with url field defined
[x] Component was added to upload job
[x] Component was added to build job
[ ] Optional: Component contains unit tests
[ ] CI passing

Change description

Relax the IDF version dependency for qrcode component till IDF v4.0

CLAassistant commented 10 months ago

All committers have signed the CLA.

igrr commented 10 months ago

Just keep in mind that we don't actually test anything older than IDF v4.3 in idf-extra-components, and we will remove v4.3 testing at the end of December when that release becomes EoL. So if the component becomes incompatible with the declared minimal supported IDF version, we won't notice this.

vikramdattu commented 10 months ago

Just keep in mind that we don't actually test anything older than IDF v4.3 in idf-extra-components, and we will remove v4.3 testing at the end of December when that release becomes EoL. So if the component becomes incompatible with the declared minimal supported IDF version, we won't notice this.

@igrr I think that should be fine. Not having strong opinions here, but maybe we make some exceptions and have some of the components also get tested for the older IDF builds? (But again, that opens door for more and more components :( )

vikramdattu commented 7 months ago

@igrr as per pervious discussion, we should be okay with CI not running with older IDFs. Besides this particular component only use esp_err and esp_log.