search

espressif / idf-extra-components

Additional components for ESP-IDF, maintained by Espressif
143 stars 86 forks source link

docs(led_strip): add api reference #265

Closed suda-morris closed 10 months ago

suda-morris commented 10 months ago

Added api.md according to approach described in https://github.com/espressif/idf-extra-components/issues/248

Fixed the wrong mem_block_num configuration in the led_strip_rmt_dev_idf4.c

espzav commented 10 months ago

Hi @suda-morris Thank you for fix my issues. I am sorry about that. I don't understand memory blocks setting, which you fixed.

Please, could you add one another fix before merging: https://github.com/espressif/idf-extra-components/commit/b0f85ca5c474c36795a30f99871375740792862d

Thank you very much.

suda-morris commented 10 months ago

@espzav Never mind, it's indeed confusing between "mem block symbols" and "mem block num". Thanks for finding a new issue. I have fixed it in the PR as well, together with other clean up.

espzav commented 10 months ago

@suda-morris Thank you very much!