espressif / idf-extra-components

Additional components for ESP-IDF, maintained by Espressif
143 stars 86 forks source link

onewire_bus: CONFIG_RMT_ISR_IRAM_SAFE cannot be enabled (IEC-69) #266

Closed kriegste closed 10 months ago

kriegste commented 10 months ago

Answers checklist.

General issue report

CONFIG_RMT_ISR_IRAM_SAFE cannot be enabled, because onewire_rmt_rx_done_callback is not in IRAM. https://github.com/espressif/idf-extra-components/blob/master/onewire_bus/src/onewire_bus_impl_rmt.c#L166

kriegste commented 9 months ago

Ah, cool. Thanks. You could have written

#if CONFIG_RMT_ISR_IRAM_SAFE
    IRAM_ATTR
#endif

but that does not matter for me.