Closed o-marshmallow closed 8 months ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
0 tests ±0 0 :heavy_check_mark: ±0 0s :stopwatch: ±0s 0 suites ±0 0 :zzz: ±0 0 files ±0 0 :x: ±0
Results for commit 0db31a49. ± Comparison against base commit 00e11af7.
:recycle: This comment has been updated with latest results.
Oh, you also need to add the new component in a few places:
as well as:
otherwise LGTM! Thanks @o-marshmallow
Oh, you also need to add the new component in a few places:
- example build rule in .build-test-rules.yml — enable the build if IDF version is >= 5.3
- upload job in .github/workflows/upload_component.yml
- test app, test_app/CMakeLists.txt — add a similar block for IDF >=5.3
- issue template bug-report.yml
as well as:
- install pre-commit and use it to fix formatting
I just updated the PR accordingly, please check again
The unrelated build failure will be fixed in https://github.com/espressif/idf-extra-components/pull/283
Implement the virtual QEMU RGB panel driver as part of
idf-extra-components
instead of esp-idf. This PR includes an API for initializing the virtual QEMU RGB panel application, an implementation for this API as well as an example that shows how to use it in correlation with LVGL.Checklist
url
field defined