espressif / idf-extra-components

Additional components for ESP-IDF, maintained by Espressif

143 stars 86 forks source link

feat(esp_qemu_rgb_panel): implement 16bpp QEMU RGB panel (IEC-77) #287

Closed horw closed 7 months ago

horw commented 8 months ago

Checklist

[ ] Component contains License
[ ] Component contains README.md
[ ] Component contains idf_component.yml file with url field defined
[ ] Component was added to upload job
[ ] Component was added to build job
[ ] Optional: Component contains unit tests
[ ] CI passing

Change description

Please describe your change here

CLAassistant commented 8 months ago

All committers have signed the CLA.

horw commented 8 months ago

Thank you for this improvement! I left a few remarks

Thanks for the review! The remark has been resolved.

suda-morris commented 7 months ago

should we upgrade the component version?

o-marshmallow commented 7 months ago

Changes, LGTM!

igrr commented 7 months ago

Please also bump the version in idf_component.yml.

horw commented 7 months ago

Please also bump the version in idf_component.yml.

Yes sure, has been bumped to 1.0.1.

igrr commented 7 months ago

@horw Looks good, just two final things:

Please click through the CLA (link in the 2nd comment)
Please fetch the latest master and rebase your branch.

igrr commented 7 months ago

@horw There are still some failing jobs, could you please take a look? For example here pytest-embedded has failed to install.

horw commented 7 months ago

@igrr, from what I can see, the main issue with the failed job was primarily related to cryptography. Therefore, I have changed the pip install flag from --only-binary to --prefer-binary for the cryptography package.

igrr commented 7 months ago

Looks like there is one more thing to update, it is this sentence in the readme file:

Please note that the virtual RGB panel currently only supports ARGB8888 (32-bit) color mode.