Closed horw closed 7 months ago
Thank you for this improvement! I left a few remarks
Thanks for the review! The remark has been resolved.
should we upgrade the component version?
Changes, LGTM!
Please also bump the version in idf_component.yml.
Please also bump the version in idf_component.yml.
Yes sure, has been bumped to 1.0.1.
@horw Looks good, just two final things:
master
and rebase your branch.@horw There are still some failing jobs, could you please take a look? For example here pytest-embedded has failed to install.
@igrr, from what I can see, the main issue with the failed job was primarily related to cryptography. Therefore, I have changed the pip install
flag from --only-binary
to --prefer-binary
for the cryptography package.
Looks like there is one more thing to update, it is this sentence in the readme file:
Please note that the virtual RGB panel currently only supports ARGB8888 (32-bit) color mode.
Checklist
url
field definedChange description
Please describe your change here