espressif / idf-extra-components

Additional components for ESP-IDF, maintained by Espressif
136 stars 85 forks source link

Add ccronexpr components for parse CRON expression (IEC-88) #304

Closed ESP-YJM closed 1 month ago

ESP-YJM commented 5 months ago

Checklist

Change description

Please describe your change here

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

ESP-YJM commented 3 months ago

@igrr Sorry for taking so long to update. If you have time, please help to review it again.

igrr commented 2 months ago

@ESP-YJM LGTM aside the few things mentioned.

igrr commented 2 months ago

@ESP-YJM Thanks for the fixes, just one more thing seems to be remaining:

/__w/idf-extra-components/idf-extra-components/supertinycron/examples/cron_example/main/cron_example_main.c
/__w/idf-extra-components/idf-extra-components/supertinycron/examples/cron_example/main/cron_example_main.c:234:6: error: function declaration isn't a prototype [-Werror=strict-prototypes]
  234 | void check_calc_invalid()
      |      ^~~~~~~~~~~~~~~~~~
/__w/idf-extra-components/idf-extra-components/supertinycron/examples/cron_example/main/cron_example_main.c:282:6: error: function declaration isn't a prototype [-Werror=strict-prototypes]
  282 | void test_expr()
      |      ^~~~~~~~~
/__w/idf-extra-components/idf-extra-components/supertinycron/examples/cron_example/main/cron_example_main.c:634:6: error: function declaration isn't a prototype [-Werror=strict-prototypes]
  634 | void test_parse()
      |      ^~~~~~~~~~
/__w/idf-extra-components/idf-extra-components/supertinycron/examples/cron_example/main/cron_example_main.c:861:6: error: function declaration isn't a prototype [-Werror=strict-prototypes]
  861 | void test_bits()
      |      ^~~~~~~~~
/__w/idf-extra-components/idf-extra-components/supertinycron/examples/cron_example/main/cron_example_main.c:896:6: error: function declaration isn't a prototype [-Werror=strict-prototypes]
  896 | void app_main()
      |      ^~~~~~~~

Please use (void) in function declarations inside the example to avoid strict-prototypes errors.

igrr commented 1 month ago

@ESP-YJM Thank you for the contribution!