espressif / idf-extra-components

Additional components for ESP-IDF, maintained by Espressif

136 stars 85 forks source link

fix(freetype): Remove system lib dependencies (IEC-103) #319

Closed espressif2022 closed 2 months ago

espressif2022 commented 3 months ago

Checklist

[ ] Component contains License
[ ] Component contains README.md
[ ] Component contains idf_component.yml file with url field defined
[ ] Component was added to upload job
[ ] Component was added to build job
[ ] Optional: Component contains unit tests
[ ] CI passing

Change description

Remove system lib dependencies: If the package required by find_package (such as BrotliDec, HarfBuzz) exists locally on Linux, the local lib will be used, causing compilation failure. -- Found BrotliDec: /usr/include (found version "1.0.9") -- HarfBuzz (required): /usr/lib/x86_64-linux-gnu/libharfbuzz.so /usr/include/stdlib.h:258:25: error: '_Float64x' is not supported on this target

igrr commented 3 months ago

@espressif2022 Could you please update the description, which issue does the PR fix? Is it a Linux-specific issue? I wonder why we didn't encounter it when this component gets built in CI.

espressif2022 commented 3 months ago

@espressif2022 Could you please update the description, which issue does the PR fix? Is it a Linux-specific issue? I wonder why we didn't encounter it when this component gets built in CI.

This is related to the system version. For recently installed ubuntu, find_package will find the following system library problems, resulting in failed compilation, check that the package does exist locally. If it does not exist in the local system, it can be compiled OK. I can't overwrite the option in sub cmake, so I want to ignore the system path here. -- Found BrotliDec: /usr/include (found version "1.0.9") -- HarfBuzz (required): /usr/lib/x86_64-linux-gnu/libharfbuzz.so

igrr commented 2 months ago

I see, thanks for explaining. I can reproduce the issue on macOS as well now, provided I install these libraries. I suppose we will need a more general solution since we can't possibly know all the possible include paths on all the systems.

I'm okay with merging this workaround first, though.

igrr commented 2 months ago

@espressif2022 I've opened https://github.com/espressif/idf-extra-components/pull/320 as a slightly more future-proof solution to the external dependencies issue.