search

espressif / idf-extra-components

Additional components for ESP-IDF, maintained by Espressif
136 stars 85 forks source link

fix(onewire): raise recovery time to support more sensor on longer wire (IEC-111) #329

Closed muggenhor closed 1 month ago

muggenhor commented 2 months ago

Change description

Specifically this is the time that's necessary to be able to perform a device search on a bus consisting of >= 6 devices on >= 10m of wire at 5V with a 4.7 kΩ pull-up resistor.

CLAassistant commented 2 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

muggenhor commented 2 months ago

I'm not signing a contract with a company I don't know (the CLA). I also don't believe this single change in number is copyrightable (not an "original work"). So feel free to regard this PR as a bug report with suggested fix direction instead.

EDIT: Also, at a glance, this CLA seems to be about grants of copyright license and patent. Both are already covered by the Apache 2.0 license which by my act of creating this PR I've implicitly agreed to. So this feels like extra "Cover Your Ass" legalese on top of that. And I'm not willing to hire a lawyer to verify that there's no hidden sneaky stuff in here.

suda-morris commented 1 month ago

I will bump up the version of onewire component later

muggenhor commented 1 month ago

Thanks for merging this! :)