espressif / idf-extra-components

Additional components for ESP-IDF, maintained by Espressif

136 stars 85 forks source link

feat(coap): libcoap 4.3.5rc1 code (IEC-119) #338

Closed mrdeep1 closed 2 weeks ago

mrdeep1 commented 1 month ago

Checklist

[ ] Component contains License
[ ] Component contains README.md
[ ] Component contains idf_component.yml file with url field defined
[ ] Component was added to upload job
[ ] Component was added to build job
[ ] Optional: Component contains unit tests
[ ] CI passing

Change description

Add in support for libcoap version 4.3.5rc1.

hmalpani commented 4 weeks ago

Footprint impact:	Example	New Firmware Size	Old Firmware Size	Difference
coap_client	956056	951620	4436
coap_server	964168	959084	5084

mahavirj commented 3 weeks ago

Footprint impact: Example New Firmware Size Old Firmware Size Difference coap_client 956056 951620 4436 coap_server 964168 959084 5084

@mrdeep1 Any thoughts on the code size impact after this change?

mrdeep1 commented 3 weeks ago

Any thoughts on the code size impact after this change?

Nothing in particular stands out. I would not have thought the extra code for multi-thread support would have added a lot as it is mainly no-op type code if not enabled but does have some wrapper functions.

Is this a significant jump?

It is possible to set the default for support TCP sessions to "n" which will save some code space.

I have updated the PR with your fix and bumped the code version to 4.3.5rc2.

mahavirj commented 2 weeks ago

Nothing in particular stands out. I would not have thought the extra code for multi-thread support would have added a lot as it is mainly no-op type code if not enabled but does have some wrapper functions. Is this a significant jump?

It should be okay, just wanted to check if its due to any of the newly added config options. But I checked, its in general because of the baseline update. I will proceed for the merge here.