Closed UnTraDe closed 1 month ago
Changes look good to me!
It would be great if you could clean up the commit history in this branch. (If not, no issue, I can do it for you before merging.)
Do you mean to rebase? Or squash?
Do you mean to rebase? Or squash?
If doing an interactive rebase (git rebase -i
or an equivalent in a GUI tool) I would use "fixup" instead of "squash" since the intermediate commit messages are not so useful. Please also make the final commit message in Conventional Commits format, e.g. change(spi_nand_flash): use 32-bit sector size and id
.
If doing an interactive rebase (
git rebase -i
or an equivalent in a GUI tool) I would use "fixup" instead of "squash" since the intermediate commit messages are not so useful. Please also make the final commit message in Conventional Commits format, e.g.change(spi_nand_flash): use 32-bit sector size and id
.
@igrr Anything else before merging?
Checklist
url
field definedChange description
The
dhara
library uses thedhara_sector_t
(typedef uint32_t dhara_sector_t
) to address sectors internally. This PR changes the component's interface to acceptuint32_t
sector id where applicable. This change will allow to utilize the entire capacity of NAND chips with more than 2^16 sectors As discussed in https://github.com/espressif/idf-extra-components/pull/327#issuecomment-2178401347