search

espressif / idf-extra-components

Additional components for ESP-IDF, maintained by Espressif
151 stars 93 forks source link

Change/led strip dependency #363

Closed suda-morris closed 2 months ago

suda-morris commented 2 months ago

Closes https://github.com/espressif/idf-extra-components/issues/361

igrr commented 2 months ago

@suda-morris thanks for the PR! LGTM aside from two questions.

igrr commented 2 months ago

@suda-morris could you please also bump the version in idf_component.yml, so that the changes get released? And update the changelog file.

suda-morris commented 2 months ago

@suda-morris could you please also bump the version in idf_component.yml, so that the changes get released? And update the changelog file.

Hi @igrr Do we want to bump the version every time we made a change? This change doesn't affect the functionality of led_strip in fact, so I want to bump the version in the next time when we have a new feature or a bugfix. e.g. in https://github.com/espressif/idf-extra-components/pull/344

igrr commented 2 months ago

I think it does improve developer experience because the time for the full build with IDF v5.3 can now be shorter. So from my perspective, it's worth publishing the release. Besides, there is almost no cost associated with publishing the new version.

If you plan to merge #344 soon then I don't mind bumping the version after that one, either.

Still, I would add a changelog entry as part of this PR so that this change isn't forgotten about.