Release online-2.21-beta-01 - Ignoring existing MSVC Buil Tools during install.

ChrisJones79 commented 1 year ago

FYI: Installer created a new Build Tools instance when installing. Didn't check existing installation. I did select v5.0.1 and installed Rust options. During MSVC installation, Visual Studio Installer had Build Tools (2). I'm attaching build logs, I think. Had previous installation of xtensa Rust toolchain v1.68.0, espup <v0.3.2.

Some existing software was recognized and utilized or upgraded but not MSVC Build Tools / Win11 SDK v10.0.22621

I will attach my what I can from that single install event:

Setup Log 2023-03-15 #001.txt

dd_vs_build_tools_decompression_log.txt

dd_bootstrapper_20230315081411.log

dd_installer_20230315081412.log

dd_installer_elevated_20230315081416.log

dd_setup_20230315081656.log

dd_setup_20230315081417.log

ChrisJones79 commented 1 year ago

Is this the reason?:

Telemetry property VS.SetupEngine.Id : VisualStudio/17.5.2+33502.453

Then,

[3bc4:000a][2023-03-15T08:14:18] Compatible ProductCode '{F23B70A8-9367-4AFE-9D16-EB4B2BD66DB5}' found for package 'Microsoft.VisualStudio.MinShell.Msi,version=17.5.33306.270,productarch=x86'
[3bc4:000a][2023-03-15T08:14:18] Compatible package version is less than or equal to the package version. Code '{F23B70A8-9367-4AFE-9D16-EB4B2BD66DB5}' will not be used for repair/uninstall attempts.

georgik commented 1 year ago

Thank you for report @ChrisJones79 The installer is not checking previous installation of VS Tools. It just invokes the installer of VS Tools which should do the check of integrity on their own. Rustup itself has now support for bootstrapping those tools, so we will probably remove the duplication of this procedure from the installer and let the rustup do the job of boostrapping requirements.

ChrisJones79 commented 1 year ago

I've been so excited to learn rust for esp32 but I've had a pretty hard time getting everything working.

So thank you very much @georgik and team. Everything that makes that ecosystem stronger is very much appreciated!

georgik commented 1 year ago

@ChrisJones79 Thank you for your feedback. Bootstrapping Rust on Windows is slightly more complex than one would expect.

I would like to ask you for some more details. Right now, we're using the following commands to deploy Windows SDK.

vs_build_tools.exe --passive --wait --add Microsoft.VisualStudio.Component.VC.Tools.x86.x64 --add Microsoft.VisualStudio.Component.Windows11SDK.22621

Code: https://github.com/espressif/idf-installer/blob/test/release-2.21/src/InnoSetup/PreInstall.iss#L267

The Component ID is derived from this list: https://learn.microsoft.com/en-us/visualstudio/install/workload-component-id-vs-build-tools?view=vs-2022

What versions of VC Tools/SDK were deployed on your system and were not taken into account? We can somehow modify the result of vs_build_tools CLI based on selector of Component ID.

In my case I've deployed it on clean Windows 11 Sandbox and the installation deployed VC Tools and Windows11SDK. The second time I run the command it was using already deployed version.

BTW: Workaround is to use rustup-init.exe in interactive mode. When it detects that VC Tools or Windows11SDK is missing it will prompt user to install it. Unfortunatelly the rustup feature does not support non-interactive mode, which we need for smooth deployment.

georgik commented 1 year ago

The new release 2.21 is available. Feel free to re-open in case of problem.

ChrisJones79 commented 1 year ago

Thank you. I'm sorry I wasn't able to respond in a timely manner. Life has been complicated. I appreciate the help and will try the new installer.

On Fri, Mar 31, 2023, 05:38 Juraj Michálek @.***> wrote:

The new release 2.21 is available. Feel free to re-open in case of problem.

— Reply to this email directly, view it on GitHub https://github.com/espressif/idf-installer/issues/176#issuecomment-1491636200, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACY6C5JJFHUVECIRFZT67ZDW62QYNANCNFSM6AAAAAAV3XXZGA . You are receiving this because you were mentioned.Message ID: @.***>

espressif / idf-installer

Release online-2.21-beta-01 - Ignoring existing MSVC Buil Tools during install. #176