fix(performcmdinstall): Exit blocking wait loop after some time to no…

espressif / idf-installer

ESP IDF Windows Installer

https://dl.espressif.com/dl/esp-idf/

101 stars 21 forks source link

fix(performcmdinstall): Exit blocking wait loop after some time to no… #250

Closed jakub-kocka closed 1 week ago

jakub-kocka commented 1 week ago

When there is no successful exit-code from the function that is the Installer waiting for, there is no mechanism to exit from this loop which causes the installation process to hang in this state indefinitely. Since the issue mentioned by the user can not be reproduced, I have tested this with the new build of online installer and everything seems to work.

This PR is a proposal to fix this.

Closes https://github.com/espressif/esp-idf/issues/13967

jakub-kocka commented 1 week ago

Thank you, for the review. I have added explaining comments about the number and rounded it.

I am merging this since the change does not affect anything and should be the solution to the issue mentioned.