fix: IDE Installer asset name uploaded on server

espressif / idf-installer

ESP IDF Windows Installer

https://dl.espressif.com/dl/esp-idf/

102 stars 21 forks source link

fix: IDE Installer asset name uploaded on server #282

Closed jakub-kocka closed 3 weeks ago

jakub-kocka commented 1 month ago

Description

Updated IDE Installer URL for the Espressif server to correspond with the download page and the other installers
Adjusted GH release creation to not be draft and pre-release

It would be better to manage the executable name generation in the scope of the calling workflow, but this would probably require passing artifacts. Since this installer is in the "feature freeze" state, this is the low-effort solution.

Job with the bad URL: https://github.com/espressif/idf-installer/actions/runs/11214781512/job/31170576041

jakub-kocka commented 3 weeks ago

All the IDE installer executables on Espressif's server would need to be renamed to correspond with the defined way because another IDE installer release was released before this PR got merged (it should be 1 file).

@tomassebestik, can you please help with this as soon as you have time?

TODO:

[x] Manually update an index.html when the executable files are renamed

jakub-kocka commented 3 weeks ago

Thanks @tomassebestik for the review, I am merging this.

espressif / idf-installer

fix: IDE Installer asset name uploaded on server #282

Description

Related