search

espressif / rust-esp32-example

Example of Rust integration into an ESP-IDF project, for ESP32 series of chips
MIT License
436 stars 36 forks source link

rust-xtensa instructions for Ubuntu 20 doesn't works on zsh #16

Closed pmnxis closed 3 years ago

pmnxis commented 3 years ago

Related files : docs/rust-on-xtensa-installation-x86_64-unknown-linux-gnu.md Description : 

zsh: command not found: pushd
zsh: command not found: popd

Suggest to change pushd and popd to cd somepath , cd ..

pmnxis commented 3 years ago

seems some ubuntu works but others not work. Don't know exact reason :(, But I think cd should work.

georgik commented 3 years ago

@pmnxis Thank you for reporting the issue. That's really interesting. Just from curiosity, which version of zsh do you have? Type: zsh --version I was testing Ubuntu 20 zsh 5.8 (x86_64-ubuntu-linux-gnu) and it was working fine.

I'll check whether we can run the Rust installation scripts even without push/pop/cd commands to simplify the manual.

georgik commented 3 years ago

@pmnxis I've made test with Rust installer and it's not necessary to change into the directory with the package. Here's updated manual which also contains new LLVM with clang: #15 Please check the manual from this branch: https://github.com/espressif/rust-esp32-example/blob/feature/llvm-toolchain/docs/rust-on-xtensa-installation-x86_64-unknown-linux-gnu.md

pmnxis commented 3 years ago

@georgik it was version 5.7. After do sudo apt upgrade -y, I can use pushd and popd very well with latest version 5.8. Also I checked the new script, looks fine :)

georgik commented 3 years ago

Thank you for the feedback.

georgik commented 3 years ago

Solved by #15 which contains instructions to new version without popd/pushd