espressif / vscode-esp-idf-extension

Visual Studio Code extension for ESP-IDF projects
Apache License 2.0
1.02k stars 298 forks source link

ESPTOOL_WRAPPER is ignored by the flash task (VSC-1392) #1215

Closed snake-4 closed 2 months ago

snake-4 commented 3 months ago

OS

Windows

Operating System version

Windows 11

Visual Studio Code version

1.90.1

ESP-IDF version

5.3

Python version

3.11.2

Doctor command output

Not applicable.

Extension

Not applicable.

Description

https://github.com/espressif/vscode-esp-idf-extension/blob/9096b398b3495cb549e4b916a76a14705b805e34/src/flash/flashTask.ts#L177 https://github.com/espressif/vscode-esp-idf-extension/blob/9096b398b3495cb549e4b916a76a14705b805e34/src/qemu/mergeFlashBin.ts#L171

The functions above do not prepend the ESPTOOL_WRAPPER environment variable to the command. Default behavior of idf.py is to prepend this to all esptool.py invocations.

Debug Message

Not applicable.

Other Steps to Reproduce

Not applicable.

I have checked existing issues, online documentation and the Troubleshooting Guide

github-actions[bot] commented 2 months ago

This issue has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities