search

espressif / vscode-esp-idf-extension

Visual Studio Code extension for ESP-IDF projects
Apache License 2.0
1.03k stars 301 forks source link

idf.preBuildTask appends build path before command (VSC-1417) #1232

Closed isMyNameLuis closed 2 months ago

isMyNameLuis commented 3 months ago

OS

Windows

Operating System version

Windows 11

Visual Studio Code version

Vscode 1.90.2 with esp-idf extension v1.8.0

ESP-IDF version

5.2.2

Python version

3.11.4

Doctor command output

report.txt

Extension

No response

Description

I have the preBuildTask defined as bellow: "idf.preBuildTask": "${idf.pythonBinPathWin} ${workspaceFolder}/utils/prebuild.py ${workspaceFolder}"

Unfortunately when building it seems like, since last update, the path of the build directory is pre-appended to the preBuildTask command.

` * Executing task: c:\Users\luisp\Documents\code\wmini-secc-esp32\build\${idf.pythonBinPathWin} c:\Users\luisp\Documents\code\wmini-secc-esp32\utils\prebuild.py c:\Users\luisp\Documents\code\wmini-secc-esp32

Debug Message

*  Executing task: c:\Users\luisp\Documents\code\wmini-secc-esp32\build\${idf.pythonBinPathWin} c:\Users\luisp\Documents\code\wmini-secc-esp32\utils\prebuild.py c:\Users\luisp\Documents\code\wmini-secc-esp32  

 *  The terminal process failed to launch: Path to shell executable "c:\Users\luisp\Documents\code\wmini-secc-esp32\build\${idf.pythonBinPathWin} c:\Users\luisp\Documents\code\wmini-secc-esp32\utils\prebuild.py c:\Users\luisp\Documents\code\wmini-secc-esp32" does not exist.

Other Steps to Reproduce

No response

I have checked existing issues, online documentation and the Troubleshooting Guide

radurentea commented 3 months ago

Hi @isMyNameLuis thanks for the bug reprot. It seems to be an issue with the release version 1.8.0. I will work on a fix today, until it gets fixed, the solution would be to revert the version back to 1.7.1.

You can do so with this .vsix file: https://github.com/espressif/vscode-esp-idf-extension/releases/download/v1.7.1/esp-idf-extension-1.7.1.vsix

Release versions can be found here: https://github.com/espressif/vscode-esp-idf-extension/releases

isMyNameLuis commented 3 months ago

Hi @isMyNameLuis thanks for the bug reprot. It seems to be an issue with the release version 1.8.0. I will work on a fix today, until it gets fixed, the solution would be to revert the version back to 1.7.1.

You can do so with this .vsix file: https://github.com/espressif/vscode-esp-idf-extension/releases/download/v1.7.1/esp-idf-extension-1.7.1.vsix

Release versions can be found here: https://github.com/espressif/vscode-esp-idf-extension/releases

Thank you. Yes in the meantime I've already agreed with the team to rollback while we wait for the fix.

radurentea commented 3 months ago

Hi @isMyNameLuis,

I've created a fix for this, could you test this version by installing the extension using the following .vsix file? esp-idf-extension.vsix.zip

isMyNameLuis commented 3 months ago

Hello @radurentea ,

Tested and is working perfectly, thank you!

github-actions[bot] commented 2 months ago

This issue has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities