espressif / vscode-esp-idf-extension

Visual Studio Code extension for ESP-IDF projects
https://docs.espressif.com/projects/vscode-esp-idf-extension/en/latest/
Apache License 2.0
1.06k stars 304 forks source link

add kconfig name to info message #1241

Closed brianignacio5 closed 3 months ago

brianignacio5 commented 4 months ago

Description

Add KConfig name to SDK Configuration Editor setting information message.

Fix "save" l10n translation in SDK Configuration Editor.

Remove wheel event on int elements in SDK Configuration Editor to avoid increase or decrease value when scroll.

Fixes #1240

Fixes #1236

Fixes #1189

Type of change

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "ESP-IDF: SDK Configuration Editor "
  2. Click (i) icon on any setting, you should see the config name in the information.
  3. If vscode language is chinese, save button translation should be fixed.

Test Configuration:

Checklist

github-actions[bot] commented 4 months ago

Download the artifacts for this pull request:

AndriiFilippov commented 4 months ago

@brianignacio5 hi !

Remove wheel event on int elements in SDK Configuration Editor to avoid increase or decrease value when scroll. ✔️ Fix "save" l10n translation in SDK Configuration Editor. ✔️ image

Would you mind to update UI: from this: image

to maybe this: image

brianignacio5 commented 4 months ago

@brianignacio5 hi !

Remove wheel event on int elements in SDK Configuration Editor to avoid increase or decrease value when scroll. ✔️ Fix "save" l10n translation in SDK Configuration Editor. ✔️ image

Would you mind to update UI: from this: image

to maybe this: image

Done

AndriiFilippov commented 4 months ago

@brianignacio5 hi !

Tested under: OS - Windows 10 / Linux

LGTM 👍 Probably just small UI remark: Could we reduce gap between parts which are related to the same field ? Because it is a bit confusing for eye.

from: image to:

image