search

espresso3389 / pdfrx

pdfrx is yet another PDF viewer implementation that built on the top of pdfium. The plugin currently supports Android, iOS, Windows, macOS, Linux, and Web.
MIT License
60 stars 36 forks source link

To cancel unnecessary partial render #137

Closed yhyh0 closed 3 weeks ago

espresso3389 commented 3 weeks ago

One question, why do we have currentPartialCancelToken? Any solid reason to export this? I think it's too difficult to use such cancellation on real production apps.

yhyh0 commented 3 weeks ago

One question, why do we have currentPartialCancelToken? Any solid reason to export this? I think it's too difficult to use such cancellation on real production apps.

I don't want to expose currentPartialCancelToken neither. It's just I need to have the getter to make sure the value is the latest in the sync closure, and having the varible called __currentPartialCancelToken is too ugly...

espresso3389 commented 3 weeks ago

1.0.57 contains the PR.