espressomd / espresso

The ESPResSo package
https://espressomd.org
GNU General Public License v3.0
226 stars 183 forks source link

Tutorial 1: LJ #3818

Closed RudolfWeeber closed 3 years ago

RudolfWeeber commented 4 years ago
schlaicha commented 4 years ago

We need to add some documentation for the tutors mentoring the tutorials. I suggest we use simple markdown files for these instructions. Would doc/tutorials/01-lennard_jones/NotesForTutor.md be the right place to put this? We should then unify this for all tutorials...

schlaicha commented 3 years ago

A note on the values for the density/temperature:

The working RDF comparison is now in 697bda0e.

What is still to do: [ ] MSD / diffusion coefficient [x] Energy / error estimate plus long-range contribution -> compare with energy in Verlet's 1967 paper

schlaicha commented 3 years ago

After offline discussion with various ICP members we decided to remove the MSD part in the LJ tutorial because

The working tutorial is in c9e2817c and 0d7726a1 fixes the test cases.

Remaining todo:

[ ] add useful test for the RDF (current one did not detect visible differences) [ ] add test for the potential energy/particle

jngrad commented 3 years ago

Concerning the RDF, you can simply reduce the test tolerance from 2.5% to e.g. 0.5%, or lower, depending on well the ESPResSo RDF agrees with the paper.